Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location and line number confusing when errors occur in external files #2336

Closed
ethancrawford opened this issue Apr 12, 2020 · 0 comments · Fixed by #2470 · May be fixed by #2514
Closed

Location and line number confusing when errors occur in external files #2336

ethancrawford opened this issue Apr 12, 2020 · 0 comments · Fixed by #2470 · May be fixed by #2514
Assignees

Comments

@ethancrawford
Copy link
Collaborator

ethancrawford commented Apr 12, 2020

If you run an external file with Sonic Pi (such as having some code in the init.rb file) but this external file contains an error, the error is reported, but the location of the error is described confusingly.
For example, in the below screenshot, it exhibits a similar issue to #2334 in that the line number is one off, but in addition, the line number is in relation to the external file. This is not immediately obvious in the current implementation, as errors have only previously been handled from code directly running in the built in buffers. In addition, the location is buffer 'eval', which could use improving.
image

@ethancrawford ethancrawford self-assigned this Apr 14, 2020
SunderB added a commit to SunderB/sonic-pi that referenced this issue Jul 4, 2020
SunderB added a commit to SunderB/sonic-pi that referenced this issue Oct 4, 2020
SunderB added a commit to SunderB/sonic-pi that referenced this issue Oct 4, 2020
cmaughan pushed a commit to cmaughan/sonic-pi that referenced this issue Jan 2, 2021
SunderB added a commit to SunderB/sonic-pi that referenced this issue May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant