Add more typehints #8101
Closed
Add more typehints #8101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
force-pushed
the
feature/symfony-7
branch
from
7bb6657
to
b7365d4
Compare
jordisala1991
commented
Sep 15, 2023
core23
approved these changes
Sep 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because {reason}.
Closes #{put_issue_number_here}.
Changelog
Most of this changes were done by the steps provided here: symfony/symfony#51563
This is a first attempt, I want to try to add builds with sf 6.4 and 7.0 to ensure the build is kind of compatible (For now I saw that we have no type incompatibilities, just some tests fail)