Fixed a few TickMark issues in relation to drawing #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ems not to exist in Processing 3 anymore - added TickMark distance from component and fixed its relation to TickMark length
- implemented TickMark.setDistance(int) method to allow better positioning in respect to the slider - cleaned up after myself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope you'll want to merge these ones in.
TickMarks were acting weird (not drawing to the end of the slider) so I rewrote that part to make for better drawing and spacing.
The float x for offset never really had a float value and the .translate() was causing the offset to never make it to the end of the slider. Wit an extra layer of push/pop Matrix I was able to redraw them entirely at a computed offset :)
I also fixed an issue with setBounds (commented out).