Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ListView to Flatlist #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

marshallshen
Copy link

Background

The original problem is caused by RN deprecating ListView in favor of FlatList, a solution is merged here.

However, a better solution IMO is to upgrade ListView entirely.

Testing

yarn test result with react-native-modal-dropdown 0.70:
Screen Shot 2019-10-15 at 8 34 47 AM

yarn test result with the PR fork
Screen Shot 2019-10-15 at 8 36 45 AM

@marshallshen
Copy link
Author

@sohobloo - any updates I should make for this?

@nathan-pierotti
Copy link

I had the same issue as well. Please merge this PR

@Rahulv2492
Copy link

I am also getting same issue please merge this PR. @sohobloo

@Rahulv2492
Copy link

Any update on this @sohobloo .

@marshallshen
Copy link
Author

@Rahulv2492 : also feel free to use the forked package as we keep it up to date: https://github.com/BuildU/react-native-modal-dropdown

In your package.json you need to import it as buildu/react-native-modal-dropdown

@Gp2mv3
Copy link

Gp2mv3 commented Feb 27, 2020

Any update?
We also see the same issue in our tests.

@irekrog
Copy link

irekrog commented Mar 8, 2020

@Gp2mv3 I had a some problem and I added below line to my test. It works now.

jest.mock('deprecated-react-native-listview', () => {});

But still is a only workaround. @marshallshen's solution is better because replace depracated ListView

@ivankdev
Copy link

ivankdev commented Jun 5, 2020

++ issue, update please

@gusrodriguez
Copy link

This should be merged to make the package usable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants