Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix separator error, height dropdown error #228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vitorizkiimanda
Copy link

Separator not working, fixed by change '||' into '&&' -> logical error
Dropdown height hardcoded leading to missing height modal on dynamic options number, fixed by deleting height on style -> styling error

@michaeldawson
Copy link

Hey @vitorizkiimanda, I'm not a contributor to this library but I can let you know that your pull request can't be considered while it includes all of these unrelated changes, including changing indentation.

Try to reduce your PR to only the lines that provide the change in behaviour, which might include line 413. Also, it's not usual practice to add a line like "* Modifiedd by vitorizkiimanda on 19/01/10." with your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants