Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Scene View Document #190

Merged
merged 11 commits into from Mar 26, 2023

Conversation

softwareantics
Copy link
Owner

@softwareantics softwareantics commented Mar 25, 2023

Description

  • Created a FinalEngine.Editor.Common project that will be used to house models and services.
  • Created SceneRenderer implementation that simply cleares the scene view to a greyish colour.
    • Added support for changing projection (however, see here and here.
  • Created a SceneView which utilizes GLWpfControl, however there an issue here.
  • Added document and tool window support
    • Includes styling, base view models, etc.
    • Uses data templates, so the structure is pretty straightforward and reusable.
  • Updated application startup to use Host.CreateDefaultBuilder instead of just an IServiceCollection.
  • Added a simple way to instantiate view models.

Fixes #188

Dependencies

This PR introduces a few dependencies for the editor projects:

Type of change

  • New feature (non-breaking change which adds functionality).

How Has This Been Tested?

I added unit tests for the view models and services that we're created in this PR. I ran the application on my local machine and everything seems to be functioning as expected.

Test Configuration:

  • Operating System: Windows 10 Home
  • Hardware: Intel i7-10710U @ 1.1GHz, 32GB RAM
  • Toolchain: VS Community 2022

Screenshots

image

Possible Issues

TODO - List the issues that are created as a result of this PR.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

@softwareantics softwareantics changed the base branch from develop to epic/editor March 25, 2023 08:05
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@softwareantics softwareantics self-assigned this Mar 25, 2023
@softwareantics softwareantics linked an issue Mar 25, 2023 that may be closed by this pull request
@softwareantics softwareantics marked this pull request as ready for review March 26, 2023 11:01
@sonarcloud
Copy link

sonarcloud bot commented Mar 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@softwareantics softwareantics merged commit cba77b1 into epic/editor Mar 26, 2023
3 checks passed
@softwareantics softwareantics deleted the feature/188-scene-view-document branch March 26, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Scene View Document
1 participant