Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(Android): convert Groovy scripts to Kotlin #2126

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

alduzy
Copy link
Member

@alduzy alduzy commented May 10, 2024

Description

This PR intents to replace Groovy gradle scripts with Kotlin

Changes

  • changed .gradle files extension to .gradle.kts
  • converted scripts to Kotlin

Test code and steps to reproduce

  • check if the example apps sync and build properly (clean project and/or invalidate caches if necessary)

Checklist

@alduzy alduzy requested review from kkafar and tboba May 10, 2024 13:08
@tboba
Copy link
Member

tboba commented May 10, 2024

@alduzy hmmm, looks like Lint runner is failing, do you know what might be the cause while performing yarn lint?

@tboba tboba changed the title refactor(Android): convert Groovy scripts to Kotlin refact(Android): convert Groovy scripts to Kotlin May 10, 2024
@alduzy alduzy force-pushed the @alduzy/convert-groovy-to-kotlin branch from 8388c90 to 76728c7 Compare May 13, 2024 10:00
@alduzy alduzy force-pushed the @alduzy/convert-groovy-to-kotlin branch from 76728c7 to f416871 Compare May 13, 2024 10:17
@alduzy
Copy link
Member Author

alduzy commented May 13, 2024

There is currently a problem regarding classpath("com.android.tools.build:gradle:4.2.2") in android/build.gradle.kts as it syncs, builds and runs fine with Example, but requires min. 8.1.0 to work with FabricExample (which unfortunately does not work with Example).
Removing the dependency resolves the issue but causes lint stage of this PR to fail.
I attach the sync error below:

class com.android.build.gradle.internal.dsl.ExternalNativeBuildOptions_Decorated cannot be cast to class com.android.build.api.dsl.ExternalNativeBuildOptions (com.android.build.gradle.internal.dsl.ExternalNativeBuildOptions_Decorated is in unnamed module of loader org.gradle.internal.classloader.VisitableURLClassLoader$InstrumentingVisitableURLClassLoader @26772656; com.android.build.api.dsl.ExternalNativeBuildOptions is in unnamed module of loader org.gradle.internal.classloader.VisitableURLClassLoader$InstrumentingVisitableURLClassLoader @66e3ac0e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants