fix: change the search icon's color according to search bar's state #2068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In our project we have the following configuration:
that on Android gives us:
what happens is that because of
headerIconColor: "white"
we get this result on open:What happens is that
headerIconColor
is applied to the clear icon too, making it blend with the background.I've tried implementing a solution to set the same color as
hintTextColor
in our codebase using onOpen and onClose events but it was unstable.Changes
It makes sense to me that the color of the clear icon should follow
hintTextColor
when search is opened.What I propose is setting the color once when we land on the page and then setting it again according to search state each time
setToolbarElementsVisibility
gets calledScreenshots / GIFs
The end result:
Test code and steps to reproduce
headerSearchBarOptions
in any Screen.Checklist