Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Android): update spotless & ktlint #2053

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Feb 27, 2024

Description

Encountered some errors (seems they were looking for old CMake version (3.10.2)) & decided to bump these deps.

Changes

Ktlint: 0.43 -> 1.1.1
spotless 6.11 -> 6.22

Checklist

  • Ensured that CI passes

Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (I see that right now the CIs are failing, let's fix it first)

@kkafar
Copy link
Member Author

kkafar commented Feb 29, 2024

Yeah, I was waiting for this being released & it happened with release of ktlint 1.2.0 few hours ago. -> I bumped it, let's see whether it will work now.

distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.4-all.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is because of the too old version of Gradle that doesn't support newest Java versions. I've decided to update it in occasion.

@tboba
Copy link
Member

tboba commented Mar 5, 2024

Because of the new version of ktlint, I see that some of new rules have been introduced that changes the way how we're writing the code. @kkafar should we disable some of them, or leave the changes as they are? What do you think?

@kkafar
Copy link
Member Author

kkafar commented Apr 16, 2024

I'll get back to this PR tomorrow, resolve conflicts.

If some rules changed we should just reformat the whole kotlin codebase according to new rules.
This should not be problematic as all it would require for branches behind main to do is to cherry-pick this commit & run (for example).

@tboba
Copy link
Member

tboba commented May 6, 2024

@kkafar just a small polite bump as a reminder 😄

@kkafar
Copy link
Member Author

kkafar commented May 6, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants