Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP feat(Android): support modal stack presentation #1974

Draft
wants to merge 102 commits into
base: main
Choose a base branch
from
Draft

WIP feat(Android): support modal stack presentation #1974

wants to merge 102 commits into from

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Nov 20, 2023 •
edited

@kkafar
TOREVERT: App.js & Test1649 temp changes
c2d9463
@kkafar
Add stub ScreenModalFragment
9b3c90c
@kkafar
Implement ScreenModalFragment.fragment
dcd4373
@kkafar
TOREVERT: change stackPresentation in JS example
007b19a
@kkafar
Use ScreenModalFragment wheen screen has modal stack presentation set
5a690fc
@kkafar
Add dependency on material theme 3 and use it in TestExample (potenti…
a6ffed8 
…ally TO REVERT)
@kkafar
linter
7ff64cc
@kkafar
TOREVERT: Bump native deps & kotlin version in TestsExample & lib
449b2b9
@kkafar
Display modal
8554c41
@kkafar
Make StackPresentation.MODAL temporarily transparent to make sure the…
47b1bcf 
… fragment underneath is not removed
@kkafar
Allow for dismissal
55d57cb
@kkafar
Refactor ScreenStack.rootScreen property impl
9d320c9
@kkafar
Go back button on Second screen in Test1649 (in TE)
81d6744
@kkafar
Attempt to dismiss modal via container dismiss method
75986e2
@kkafar
TOREVERT(manual): Modify Test1649
6dfbee1
@kkafar
TOREVERT: Log upon receiving native events on JS side
5b103b1
@kkafar
Bring ScreenModalFragment up to speed with main
8706e6b
@kkafar
Managed to present the fragment modally
2a3815b
@kkafar
TOREVERT: temporarily disable custom stack animations
9171cc3
@kkafar
Kotlinize implementation of ScreenStack.adapt method
e9ebb88
@kkafar
Play around with animation
e37055e
@kkafar
Stash changes in modal fragment
9ed55b7
@kkafar
Move recycleView method to a ext module
6e0036e 
It is now implemented as extension method on `View` class
@kkafar
Recycle screen before adding it to modal layout
acac110
@kkafar
Another stash of changes 🤦
9c1ba79
@kkafar
Set behaviour on screen instead of using dedicated fragment type for …
7110e03 
…standard modal
@kkafar
Some options for the modal
7c50989
@kkafar
Improve view extensions
8cb8d05
@kkafar
Rename dismiss -> dismissFromContainer
85df811
@kkafar
Add more comments into interfaces
256fa71
@kkafar
Bring back functionality of setting sheet height based on fraction pa…
612ada8 
…ssed from JS
@kkafar
Check against empty array on native side
86307aa
@kkafar
Cleanup ScreenStackFragment a bit
00d50b2
@kkafar
Bring back support for dimming view animation
c442b25
@kkafar
Remove unused function
426bee8
@kkafar
Update TestExample to use new API
c3abf7c
@kkafar
Add react-versioned files
20a7ae6
@kkafar
Remove RNSModalRootView.kt from main source set
1a0653d
@kkafar
Revert "Add react-versioned files"
6bda77c 
This reverts commit 20a7ae6.
@kkafar
Revert "Remove RNSModalRootView.kt from main source set"
2fe8144 
This reverts commit 1a0653d.
@kkafar
Temporarily remove modal functionality
57f0b43
@kkafar
Fix 3-level detet
f8e9baf
@kkafar
Update TE
cadde6a
@kkafar
Make ScreensCoordinatorLayout transparent to gestures
dafca03
@kkafar
Improve dimming view behaviour a bit
4dea550
@kkafar
Small renaming
4f47012
@kkafar
Use ViewOutlineProvider to set sheet shape instead of MaterialShapeDr…
f604827 
…awable
@kkafar
Do not set cornerradius on MaterialShapeDrawable at all
087a938
@kkafar
Cleanup attachShapeToScreen a bit
d940324
@kkafar
Use GradientDrawable to achieve effect of only top corners being rounded
1323f1a
@kkafar
Stash changes on rounded corners
52e5839
@kkafar
Restore content diplay
7cab9c2
@kkafar
Callbacks for ime inset, set temporarily push presentation as transpa…
1ca4e3d 
…rent
@kkafar
Improve sheet animation
49caf0a
@kkafar
Restore pre Android 30 keyboard behaviour
ab835b8
@kkafar
Update example in TE
77b9670
@kkafar
Merge branch 'main' into @kkafar/android-modal-refactor-4
f8b3946
@kkafar
Remove merge artifact: index.native.tsx
4479c1a
@kkafar
Update yarn.lock
72b2631
@kkafar
Update default values for sheet props
1acbdc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kkafar kkafar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

presentation="modal" not working on android
1 participant
@kkafar