Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iOS): introduce modal dismiss event on drag down attempt #1959

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gtokman
Copy link

@gtokman gtokman commented Nov 4, 2023

Description

As described in this discussion, this PR intercepts the event when a user tries to drag down the view, allowing to perform additional actions, such as displaying an Action Sheet for confirmation.

Changes

  • Updated types.tsx
  • RNSScreen.h
  • RNSScreen.mm

Screenshots / GIFs

test.mp4

Test code and steps to reproduce

Not yet, but requires gestureEnabled: false and onModalDismiss: () => showActionSheet()

Checklist

@tboba
Copy link
Member

tboba commented Nov 6, 2023

Hi @gtokman, thanks for opening this issue! 🥳
Unfortunately our CD is failing on the method onModalDismiss(nil) 😕 Also, I don't know if I understand the onModalDismiss prop correctly - where are we passing the logic of this function to the native code?

@tboba tboba changed the title iOS: PR intercepts the event when a user tries to drag down feat(iOS): introduce modal dismiss event on drag down attempt Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants