Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metadata manager m8s] Adding unit testcase for ListMetadata Rest API #1397

Open
wants to merge 12 commits into
base: metadata-management
Choose a base branch
from

Conversation

josephjacobmorris
Copy link
Contributor

@josephjacobmorris josephjacobmorris commented Feb 7, 2023

What type of PR is this?

/kind test

What this PR does / why we need it:

  • Adding unit test case for paginator, validator, utils

Test Report Added?:

/kind TESTED

Test Report:

  • utils.go
    image

  • paginator.go
    image

  • validator.go
    image

  • translator.go
    image

  • service.go in metadata
    image

  • service.go in api
    image

Special notes for your reviewer:

@josephjacobmorris josephjacobmorris changed the base branch from master to metadata-management February 7, 2023 10:10
Copy link
Contributor Author

@josephjacobmorris josephjacobmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self Review Done

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #1397 (ddb53ce) into metadata-management (12db78e) will not change coverage.
The diff coverage is n/a.

❗ Current head ddb53ce differs from pull request most recent head 51b9276. Consider uploading reports for the commit 51b9276 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##           metadata-management    #1397   +/-   ##
====================================================
  Coverage                48.12%   48.12%           
====================================================
  Files                       10       10           
  Lines                     1571     1571           
====================================================
  Hits                       756      756           
  Misses                     756      756           
  Partials                    59       59           

@josephjacobmorris josephjacobmorris changed the title [metadata manager m8s] Adding unit testcase for paginator, validator, utils [metadata manager m8s] Adding unit testcase for ListMetadata Rest API Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant