Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go version to 1.18 #1324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

niladrih
Copy link

@niladrih niladrih commented Apr 10, 2022

Signed-off-by: Niladri Halder niladri.halder26@gmail.com

What type of PR is this?
/kind enhancement

What this PR does / why we need it:
This PR upgrades the go version to 1.18 from 1.12. This removes the vendor directory.

Which issue(s) this PR fixes:
Fixes #1323

Test Report Added?:
/kind NOT-TESTED

Test Report:
N/A

Special notes for your reviewer:
#SODACODE2022

Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1324 (2dec741) into master (a689e17) will increase coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1324      +/-   ##
==========================================
+ Coverage   38.93%   39.13%   +0.20%     
==========================================
  Files          53       53              
  Lines        6966     9615    +2649     
==========================================
+ Hits         2712     3763    +1051     
- Misses       3739     5337    +1598     
  Partials      515      515              
Impacted Files Coverage Δ
pkg/db/drivers/etcd/client.go 0.00% <ø> (ø)
pkg/utils/urls/urls.go 39.58% <0.00%> (-8.70%) ⬇️
client/fake.go 41.76% <0.00%> (-4.10%) ⬇️
osdsctl/cli/profile.go 66.66% <0.00%> (-3.55%) ⬇️
osdsctl/cli/version.go 59.09% <0.00%> (-3.41%) ⬇️
osdsctl/cli/volumeattachment.go 70.51% <0.00%> (-3.26%) ⬇️
osdsctl/cli/pool.go 78.57% <0.00%> (-3.25%) ⬇️
osdsctl/cli/dock.go 78.04% <0.00%> (-3.21%) ⬇️
osdsctl/cli/volumegroup.go 80.64% <0.00%> (-3.14%) ⬇️
osdsctl/cli/fileshare.go 80.00% <0.00%> (-3.14%) ⬇️
... and 44 more

@sushanthakumar
Copy link
Contributor

@himanshuvar @PravinRanjan10 , pls have a look

@anvithks anvithks added SODACODE2022 SODACODE2022 Hackathon Label SODAMED SODACODE2022 Hackathon Medium Priority Label labels May 5, 2022
@sushanthakumar
Copy link
Contributor

#SODACODE-PR-ACCEPTED
This PR is accepted for SODACODE 2022. But merge will be done after appropriate testing as it involves many file changes.
Thanks @niladrih for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SODACODE2022 SODACODE2022 Hackathon Label SODAMED SODACODE2022 Hackathon Medium Priority Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the project to GO 1.18
3 participants