Add CRUD support for availability zone #1049
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-v
force-pushed
the
availability_zone
branch
from
f47bf25
to
e13ab5d
Compare
Codecov Report
@@ Coverage Diff @@
## development #1049 +/- ##
==============================================
+ Coverage 34.58% 34.69% +0.1%
==============================================
Files 97 100 +3
Lines 17849 18165 +316
==============================================
+ Hits 6173 6302 +129
- Misses 10804 10967 +163
- Partials 872 896 +24
|
wisererik
requested changes
Nov 13, 2019
pkg/api/controllers/pool_test.go
Outdated
| // assertTestResult(t, w.Code, 200) | ||
| // assertTestResult(t, output, SampleAvailabilityZones) | ||
| // }) | ||
| // } |
| // "strings" | ||
|
|
||
| // log "github.com/golang/glog" | ||
| "github.com/opensds/opensds/pkg/api/policy" |
| "github.com/opensds/opensds/pkg/model" | ||
| // "github.com/opensds/opensds/pkg/utils/constants" | ||
| ) | ||
|
|
|
|
||
| // An OpenSDS zone is identified by a unique name and ID. | ||
| type ZoneSpec struct { | ||
| *BaseModel |
There was a problem hiding this comment.
please use AvailabilityZoneSpec
joseph-v
force-pushed
the
availability_zone
branch
6 times, most recently
from
aaedd1f
to
189aa20
Compare
joseph-v
changed the title
joseph-v
force-pushed
the
availability_zone
branch
from
189aa20
to
baf8708
Compare
| Url: urls.GenerateZoneURL(urls.Etcd, "", zoneID), | ||
| } | ||
| dbRes := c.Get(dbReq) | ||
| if dbRes.Status != "Success" { |
There was a problem hiding this comment.
what will be the behaviour if c.Get() returns null or errornous code?
| } | ||
| dbRes := c.Get(dbReq) | ||
| if dbRes.Status != "Success" { | ||
| log.Error("When get zone in db:", dbRes.Error) |
There was a problem hiding this comment.
message should start with lower case.
please also change the below line nos with lower case
line no: 1348, 1385, 1418, 1431, 1441
| azExists := false | ||
| azs, err := dr.c.ListAvailabilityZones(ctx) | ||
| if err != nil { | ||
| log.Errorf("When list zone %s in db: %v\n", pol.AvailabilityZone, err) |
There was a problem hiding this comment.
same here. And please take a look of all files about lower case starting letter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds Create/Update/List/Delete operations on availability zone so that management of zone is more flexible.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #1040Special notes for your reviewer: Implementation is in progress
Release note: