Update installments generator options and add a new utility function for determining the generator options #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m number of installments
…mining the options, outside of the wrapper or plugin scripts
tugayRad
force-pushed
the
update-installments-generator-options
branch
from
1c97a39
to
8e3bb47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thanks for the plugin implementations.
We are using the installments plugin in the Radity and we extend it a bit to fulfill our needs.
Made some generic updates to the plugin so that we can receive updates more easily, with less conflicts.
9d12c78 is for determining the maximum number of installments that will be generated with the plugin. It only passes the option to the
getDateSequencemethod asmaxCountparameter.b7e4df7 is for creating a center to determine the generator options outside of the wrapper or plugin scripts. By doing this we aim to have less conflict while we pull your updated codes and merge them with our business logic.