o/devicestate, o/ifacestate: fix mocking in unit tests #13963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install mode unit tests block unexpectedly when snapd on the host isn't running. This is caused by missing mocking, so the `snap changes` command called at the end of the installation process was hitting the actual snapd process runnig on the host machine. Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
Interface manager asserts whether the snapd.apparmor.service is enabled, but the tests were missing proper mocking of this helper. In this case, on hosts where the snapd.apparmor.service was present but not installed, the check would fail and thus ifacemgr would push a warning indicating a possible issue, which the braks the tests, such as interfaceManagerSuite.TestBadInterfacesWarning. Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
bboozzoo
added
Simple 😃
zyga
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some unit tests fail unexpectedly on hosts where snapd has been installed through the package, but its services have not been enabled (or started).