daemon: attach affected-snaps data to tasks #13953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeyadYasser
added
Needs Samuele review
github-actions
bot
added
the
Needs Documentation -auto-
sergio-costas
approved these changes
May 8, 2024
zyga
approved these changes
May 22, 2024
bboozzoo
reviewed
May 22, 2024
overlord/snapstate/conflict.go
Outdated
| @@ -76,7 +76,7 @@ func RegisterAffectedSnapsByKind(kind string, f AffectedSnapsFunc) { | |||
| affectedSnapsByKind[kind] = f | |||
| } | |||
|
|
|||
| func affectedSnaps(t *state.Task) ([]string, error) { | |||
| func AffectedSnapsByTask(t *state.Task) ([]string, error) { | |||
There was a problem hiding this comment.
reading the name it feels like this should return some sort of a map of task id -> list of affected snaps. How about SnapsAffectedByTask?
There was a problem hiding this comment.
Good point, updated!
pedronis
reviewed
May 23, 2024
pedronis
approved these changes
May 27, 2024
overlord/snapstate/conflict.go
Outdated
| @@ -76,6 +76,7 @@ func RegisterAffectedSnapsByKind(kind string, f AffectedSnapsFunc) { | |||
| affectedSnapsByKind[kind] = f | |||
| } | |||
|
|
|||
| // SnapsAffectedByTask returns a list of snap names affected by the given task. | |||
There was a problem hiding this comment.
"... a list of names of snaps ..." would be slightly more precise
ZeyadYasser
force-pushed
the
attach-api-affected-snaps
branch
from
6c529fe
to
f20ded0
Compare
Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
This allows API caller to associate each task with the relevant snaps which is useful in the case change progress tracking when a change is associated with multiple snaps. This exact use case is needed by snapd-desktop-integration. Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
ZeyadYasser
force-pushed
the
attach-api-affected-snaps
branch
from
f20ded0
to
0a3e5ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an iteration based on #13902 which allows
/v2/changesAPI caller to associate each task with the relevant affected snaps which is useful in the case change progress tracking per snap when a change is associated with multiple snaps.This exact use case is needed by snapd-desktop-integration.
Note: When this is merged, The REST API docs need to be updated as well.