tests/lib/fakestore/store: do not hardcode port in fakestore unit tests #13946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboozzoo
force-pushed
the
bboozzoo/fakestore-addr-in-use
branch
from
cc4f762
to
96da2e9
Compare
MiguelPires
approved these changes
May 7, 2024
valentindavid
approved these changes
May 8, 2024
The unit tests hardcode the port number, which occasionally seems to be occupied by something else when running the whole test suite on GH (most likely tests from another package). Have the port number be selected by the kernel. Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
bboozzoo
force-pushed
the
bboozzoo/fakestore-addr-in-use
branch
from
96da2e9
to
212616c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests hardcode the port number, which occasionally seems to be occupied by something else when running the whole test suite on GH (most likely tests from another package). Have the port number be selected by the kernel.
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?