Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: implement TODO in main/writable-areas from 2016 #13883

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zyga
Copy link
Collaborator

@zyga zyga commented Apr 24, 2024

Apparently we never enabled the code to check if we can write to
SNAP_USER_COMMON. Better late than never.

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

@zyga zyga force-pushed the tweak/main-writable-data-2016-todo branch from 28aed3a to 3bfddbc Compare April 24, 2024 08:19
Copy link
Collaborator

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the test will probably need details section to be added

Copy link
Collaborator

@sergiocazzolato sergiocazzolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

Apparently we never enabled the code to check if we can write to
SNAP_USER_COMMON. Better late than never.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
@zyga zyga force-pushed the tweak/main-writable-data-2016-todo branch from 3bfddbc to 5763ef0 Compare April 25, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants