Add prompting support #130
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-ancell
force-pushed
the
prompting
branch
3 times, most recently
from
0e38293
to
643ebad
Compare
robert-ancell
force-pushed
the
prompting
branch
from
643ebad
to
4cf06aa
Compare
robert-ancell
force-pushed
the
prompting
branch
from
fb32c93
to
bc401a3
Compare
robert-ancell
force-pushed
the
prompting
branch
from
bc401a3
to
34ab212
Compare
|
I set both PRs as drafts again because I want to check the new APIs, since it seems that it's not a good idea to publicly use GPtrArray or GHashTable in public, gobject-introspected, APIs https://www.bassi.io/articles/2023/02/20/bindable-api-2023/ |
|
I don't think that should block any of this work - if we're going to remove the GPtrArrays and GHashTables from the public API that's going to affect a lot of existing code, it won't be much harder to do this with the new APIs there too. Also, I don't think we're heavily using snapd-glib through introspection. |
|
Ops! Sorry, my fault. I commented in the wrong PR. I was talking about my PRs, the NOTICES PRs, not this one 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress to match the currently proposed prompting API. This will likely be updated and it not able to land until support for this lands in snapd.