Udeng 2282 refresh awareness implement new scheme

[sergio-costas]

Implements the new Refresh Awareness protocol.

DONE:

• notifications when a new update is available but blocked because it's running
• actions in the notifications of pending updates
• show progress window (but only with pulsing progress bar)
• show update complete message
• show app icon in progress window
• show true progress bar during updates
• use the visible name from the .desktop file whenever possible
• group multiple progress bars in a single window
• make "hide" button work
• change from progress mode to pulse mode after five seconds of inactivity
• tested inside a snap. Requires several patches to snapd:
  api-snaps: add refresh-observe access to /v2/snaps/{name} snapd#13931
  interfaces: give priority to desktop-launch over desktop-legacy snapd#13933
  notify: Dont send refresh complete notification if snap refresh observe is connected snapd#13936
• added failsafes to ensure that it works without those patches (although not so "cute")
• added an icon for the task bar (it shows a generic icon when a window is shown)

TO DO:

• add an icon for upper-left notifications corner (it shows a generic icon)
• add progress bar in the icon on the dock

[sergio-costas]

@robert-ancell Should I add support for FreeDesktop.org notifications, or it should be enough with the gnome ones?

[robert-ancell]

@robert-ancell Should I add support for FreeDesktop.org notifications, or it should be enough with the gnome ones?

Isn't Gio.Notification doing this for you? You don't seem to be making any explicit fdo/gnome notification calls that I can see.

[sergio-costas]

I don't know if Gio.Notification does abstract up to that point... I'll try to do some tests.

[sergio-costas]

You are right: it is supported. So nothing to do there, then. Thanks!

[sergio-costas]

@robert-ancell This is ready, with the exception of an icon for the application itself (because the notifications show the application icon too, in the top-left corner).

[sergio-costas]

Also, it is "compatible" with the current snapd version. This is: it won't be as "cute" as it will be when all the patches have landed in snapd, but it works. It doesn't show the application icon or the "visible name", and the "application is ready" notification is shown twice, but it works.

[sergio-costas]

Also, the desktop-launch interface is there just for when those patches land, but... I still don't know if that will be the definitive interface for reading the .desktop files, or will have to use a different one. If you want to launch this "as-is", maybe it would be a good idea to remove it until that patch lands... What do you think?

[robert-ancell]

Also, the desktop-launch interface is there just for when those patches land, but... I still don't know if that will be the definitive interface for reading the .desktop files, or will have to use a different one. If you want to launch this "as-is", maybe it would be a good idea to remove it until that patch lands... What do you think?

Yes, if it can be removed now do it an make a second PR to add it.

[robert-ancell]

Not a full review, we can go over again next week.

[robert-ancell]

Some minor notes, I'll leave it to you to decide if they're worth changing. (feel free to merge when you're ready).

The change is large, so I'm not 100% confident my review is exhaustive - hopefully no major issues in here!

[sergio-costas]

Done the changes. But I can't merge it, I don't have permissions.

[sergio-costas]

Anyway, there are two things remaining.

[robert-ancell]

Ok, ping me when you're ready to merge.

[sergio-costas]

@robert-ancell I think that it's better to merge this one, and do those other changes in different PRs, so please, merge this one when you have some spare time.