Wait for /dev/ubuntu/disk device to start snap-initramfs-mounts.service #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires snapcore/snapd#12006 |
|
It can often be confusing if udev database contents is different between initrd and runtime system. I hope that this udev rule will be added to the core* snap, and snapd.deb as well. Such that Links= on the system for the given partitions are the same in initrd and running systems. |
valentindavid
force-pushed
the
valentindavid/wait-for-disk
branch
from
f7a03a4
to
f65c7cb
Compare
valentindavid
changed the title
valentindavid
force-pushed
the
valentindavid/wait-for-disk
branch
from
6367f48
to
c6ba4a0
Compare
valentindavid
force-pushed
the
valentindavid/wait-for-disk
branch
8 times, most recently
from
4e008e4
to
42581e4
Compare
|
I forgot what this is for anymore. |
snap-bootstrap starts before the disk is detected, which means it needs to loop and sleep until the disk appears. This is not elegant nor efficient. This PR changes it to react to udev and starts snap-bootstrap once the disk is detected without any sleep. |
valentindavid
force-pushed
the
valentindavid/wait-for-disk
branch
from
42581e4
to
4f2267f
Compare
valentindavid
force-pushed
the
valentindavid/wait-for-disk
branch
from
4f2267f
to
9af5a90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.