Custom actions authorization #337
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smpallen99
requested changes
May 18, 2017
lib/ex_admin/table.ex
Outdated
| def build_th({field_name, opts}, table_opts) do | ||
| build_th(to_string(field_name), opts, table_opts) | ||
| end | ||
| def build_th(field_name, _), | ||
| do: th(".th-#{parameterize field_name} #{humanize field_name}") | ||
| def build_th(field_name, opts, %{fields: fields} = table_opts) do | ||
| if String.to_atom(field_name) in fields and opts in [%{}, %{link: true}] do | ||
| if opts[:link] == true do |
There was a problem hiding this comment.
Why do you think its safe to replace the original implementation? I think this may have regression issues, but I'm not sure without regressing it. Why the change?
There was a problem hiding this comment.
I added a couple of changes to this PR which are not related to the authorization logic. This part is one of them. Will do some cleanups
| @@ -23,50 +33,57 @@ defmodule ExAdminTest do | |||
|
|
|||
| @tag as_resource: %TestExAdmin.ExAdmin.Simple{} | |||
| test "action_button", %{defn: defn, conn: conn} do | |||
| result = ExAdmin.action_button(conn, defn, "Simple", :show, :edit, defn.actions, "17") | |||
| result = ExAdmin.ResourceTitleActions.action_button(conn, defn, "Simple", :show, :edit, defn.actions, "17") | |||
There was a problem hiding this comment.
Aliasing ExAdmin.ResourceTitleActions would reduce a little noise here.
| end | ||
|
|
||
| @doc false | ||
| def action_button(conn, defn, name, _page, action, actions, id \\ nil) do |
There was a problem hiding this comment.
I know this is the old code, just moved. But I'd appreciate if you could remove the nesting. Something like this (not tested):
def action_button(conn, defn, name, _page, action, actions, id \\ nil) do
with true <- action in actions,
true <- Utils.authorized_action?(conn, action, defn) do
action_name = defn.action_labels[action] || Utils.humanize(action)
[action_link(conn, "#{action_name} #{name}", action, id)]
else
_ -> []
end
end
sineed
force-pushed
the
custom-action-authorization
branch
from
810f5df
to
50afd90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #334
Things in which I'm not confident enough:
%Plug.Conn{}struct. As a compromise I think about putting:ex_admin_metadatakey insideconn.assignsmap.ExAdmin. I started to go further but realised that this is not as simple as I thought. I don't think that 7 arguments is good for functions but currently I have bad knowledge ofex_admindomain.I understand that you may not accept this PR without proper module design