Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Studio plugin: fix io.js crashes #1769

Closed
wants to merge 1 commit into from
Closed

The Studio plugin: fix io.js crashes #1769

wants to merge 1 commit into from

Conversation

Morfent
Copy link
Contributor

@Morfent Morfent commented Apr 12, 2015

Running the server on io.js never requires es6-shim since it already
supports Maps, but doesn't support Array.from(), which this uses.

Running the server on io.js never requires es6-shim since it already
supports Maps, but doesn't support Array.from(), which this uses.
@Slayer95
Copy link
Contributor

Change the condition here then I think https://github.com/Zarel/Pokemon-Showdown/blob/master/app.js#L59

EDIT: Actually, it's probably better to move away from Array.from here (or shim it ourselves), as we don't need es6-shim for anything else, and requiring it would degrade collections' performance

@monsanto
Copy link
Member

Can you guys figure this out ASAP, I want to restart main for my other patch, it'd be nice to get this one too.

EDIT: nm I am just restarting now, this can go in later

@Morfent
Copy link
Contributor Author

Morfent commented Apr 12, 2015

A polyfill already exists for it: https://github.com/es-shims/Array.from
I think it might be safer to stick with es6-shim for now, until io.js is included with the list of engines in package.json. Refactoring this to avoid using Array.from() can be done soon.

@Slayer95
Copy link
Contributor

Now that we don't depend on es6-shim, adding it back (or another dependency) for a plugin sounds like a crime ;-;

f6146b1

@Slayer95 Slayer95 closed this Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants