Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 0x09CD as keyspec_comma for as_IN and bn_IN keyboards #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove 0x09CD as keyspec_comma for as_IN and bn_IN keyboards #84

wants to merge 1 commit into from

Conversation

mdminhazulhaque
Copy link
Contributor

Hi SMC Team,

This is my 3rd PR for Indic Keyboard. Feeling great to contribute.

Anyway, for the latest release, I found that the "Bengali - Probhat" layout has a wrong key instead of Comma , (right beside the language switch key). The character 0x09CD (BENGALI SIGN VIRAMA) is used to join two or more characters into a single composite character which is obviously not a comma key.

Screenshot_20200805-034255_Keep_notes

This PR fixes the wrongly places comma for as_IN and bn_IN layout.

Screenshot_20200805-034124_Keep_notes

@jishnu7
Copy link
Member

jishnu7 commented Aug 5, 2020

Hi @mdminhazulhaque, Thanks for the PR.

The file you have modified is auto generated. It is mentioned at the top of the file.
It is generated from tools/make-keyboard-text/res/values-*.

Please make necessary changes and update the PR.

One more thing, if you are not aware, we moved development to gitlab. If you can send future updates there, that'll also be helpful - https://gitlab.com/indicproject/indic-keyboard/

@jishnu7
Copy link
Member

jishnu7 commented Aug 5, 2020

@mdminhazulhaque can you also make sure this change won't affect other layouts in as_IN and bn_IN, as in make sure the virama sign can be entered in some way in other layouts.

@mdminhazulhaque
Copy link
Contributor Author

Hi @jishnu7 thanks for the suggestions. I will fix the issues in proper XML under make-keyboard-text and put the PR in Gitlab.

For bn_* I can test and confirm. But for Assamese, need someone who speaks/writes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants