[KS-194] Send Streams reports to TriggerService #13203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
samsondav
approved these changes
May 15, 2024
| // NOTE: Skipping fields derived from FullReport, they will be filled out at a later stage | ||
| // after decoding and validating signatures. | ||
| } | ||
| return mt.triggerCapability.ProcessReport([]capMercury.FeedReport{converted}) |
There was a problem hiding this comment.
We are assuming this is async/non-blocking?
There was a problem hiding this comment.
Yes, non-blocking in a networking sense. It only saves the report in a local map under lock - implementation here: https://github.com/smartcontractkit/chainlink-common/blob/main/pkg/capabilities/triggers/mercury_trigger.go#L82
krehermann
approved these changes
May 15, 2024
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.