Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all solhint issues #13185

Merged
merged 10 commits into from
May 15, 2024
Merged

Fix all solhint issues #13185

merged 10 commits into from
May 15, 2024

Conversation

RensR
Copy link
Contributor

@RensR RensR commented May 13, 2024

Fixes all solhint issues. Teams are encouraged to look at each projects commit to see the changes made to their product.

NOTE: The CI failure is expected, as this PR fixes the solhint issues in some of the frozen files. This is fine and doesn't block merging.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Member

@justinkaseman justinkaseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for Functions

@austinborn
Copy link
Collaborator

Ty for going through this @RensR ! Looks good on Operator Forwarder.

@RensR RensR added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@RensR RensR added this pull request to the merge queue May 15, 2024
Merged via the queue into develop with commit 286e6af May 15, 2024
108 of 110 checks passed
@RensR RensR deleted the fix-solhint-issues branch May 15, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants