Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include webhook response in error message. #1516

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joshdrake
Copy link
Contributor

Pain or issue this feature alleviates:

Not having visibility in to errors during sign requests when a webhook is used.

Why is this important to the project (if not answered above):

Helps with troubleshooting eg: device attestation workflows.

馃挃Thank you!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Aug 25, 2023
@joshdrake joshdrake requested a review from maraino August 25, 2023 18:03
@joshdrake joshdrake requested a review from areed August 25, 2023 18:14
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, it won't look as expected if the response is not text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants