-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add function interface to assertItem #1469
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1469 +/- ##
============================================
- Coverage 89.37% 89.32% -0.05%
Complexity 3365 3365
============================================
Files 459 459
Lines 13399 13402 +3
Branches 1640 1640
============================================
- Hits 11975 11971 -4
- Misses 797 801 +4
- Partials 627 630 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Note: @XiangZhouWD is not affiliated to this project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure this adds much to our testing support, and at the very least this is only specific to Uni
. Do you have more complex use-cases that would justify this addition?
implementation/src/main/java/io/smallrye/mutiny/helpers/test/UniAssertSubscriber.java
Show resolved
Hide resolved
This allows for transformation, and individual properties assertion. |
🎄 Let's revisit in January. |
I'm thinking about this kind of functionality but for Multi. Maybe something like this:
Maybe there could also be a |
Hi all,
This PR is a small add-on on top of the existing methods to make assertions easier.
With this we are allowed to transform and assert as we please instead of the full item and the equals equivalency of the item.
Example