fix: make download-artifacts.sh more flexible #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
5 tasks
mihaimaruseac
approved these changes
Apr 27, 2024
ianlewis
reviewed
May 7, 2024
| # TODO: With the commands at the end of this script, only the needed files will be copied over. | ||
| # But we should get specific about which files to ignore. | ||
| ./*.zip) | ||
| unzip -o "${zip_path}" -d "${output_path}" |
There was a problem hiding this comment.
nit: I think this case makes some of the above cases obsolete.
ianlewis
approved these changes
May 7, 2024
ramonpetgrave64
added a commit
to slsa-framework/slsa-github-generator
that referenced
this pull request
May 8, 2024
# Summary A few fixes and additions to the release docs. - fix the `sed` commands - add Github container registry auth instructions related PR slsa-framework/slsa-verifier#761 ## Testing Process Manual testing locally. ## Checklist - [x] Review the contributing [guidelines](./../CONTRIBUTING.md) - [ ] Add a reference to related issues in the PR description. - [x] Update documentation if applicable. - [ ] Add unit tests if applicable. - [x] Add changes to the [CHANGELOG](./../CHANGELOG.md) if applicable. --------- Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com> Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the
download-artifacts.shscript be more useful.Before, it would error upon seeing some zip files that it doesn't expect to be in the GH release. I think the script is just a bit outdated. But for now, I think we should bypass that, since the script is already written to know which of the final files within the archives are actually needed.
related PR slsa-framework/slsa-github-generator#3589