Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change method name 'encode' to 'encodeHtml' #922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pdhung3012
Copy link

@pdhung3012 pdhung3012 commented Aug 13, 2019

This class is used to provide utilities for handling Html. The method named 'encode' is to encode an html page. Thus, the method name 'encodeHtml' is more intuitive than 'encode'.

@maniac103
Copy link
Collaborator

That method doesn't encode (to) HTML, as the new name would imply, though. It encodes HTML source into a Spannable.

@Fs00
Copy link
Contributor

Fs00 commented Dec 4, 2021

encodeToSpanned/encodeToSpannable would probably be a better name... The fact that the method belongs to the HtmlUtils class already implies that you're working with HTML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants