Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide explore section if logged in #1024

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flxholle
Copy link
Contributor

@flxholle flxholle commented Aug 30, 2020

Personally, I do not use the explore section and it makes the navigation drawer longer, than it would be needed.
I think this is only useful if the user is not logged in.

@maniac103
Copy link
Collaborator

I don't see the relationship between the explore section and the 'user is logged in status'. Personally, I use both trending list and (occasionally) the blog list despite being logged in. The only thing that probably isn't too useful for logged in users is the global GH timeline ... but at the same time, I wonder why there should be a problem in keeping it. The only item that comes after these items is 'Settings', and that surely isn't used that often?

@flxholle
Copy link
Contributor Author

Hi @maniac103
I see your point. I think this is personal decision, I do not use any of the three features and I often click on them by accident, so I removed them for myself. If you do not want this change you can close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants