Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying the compile configuration if possible #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewreeman
Copy link

@andrewreeman andrewreeman commented Aug 3, 2021

This performs a try/catch to try to maintain backwards compatibility.

Another solution would be could ditching backwards compatibility and just remove the 'compile' and 'testCompile' lines then replace:
configurations.api.getDependencies().each { dep -> addDependency(dep, "compile") }

with:
configurations.api.getDependencies().each { dep -> addDependency(dep, "implementation") }

fix #38

@akapelrud
Copy link

BUMP: Please accept this change, as #38 breaks builds on jitpack.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't reference "compile" when it's not present
2 participants