-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support to access hash index with dot separator #75
base: master
Are you sure you want to change the base?
Conversation
I've had a quick glance it and looks reasonable, I guess I'd be curious to see if Thanks for your contribution! I should be able to review more carefully, and merge, over the weekend. I did leave one minor comment already, but that's a trivial thing. |
Looks like this breaks things, in two ways: Test cases fail
Standard Library breaksOnce built with this merge-request applied (locally) I created a test program:
Running that:
So it seems like something is broken in the standard-library, as implemented beneath |
49983f1
to
fbeb168
Compare
fbeb168
to
babb608
Compare
These parts of the standard-library are the first to fail:
Commenting them out results in later failures. Something odd with the filed vs. object-method. I guess there needs to be a test that the |
…ndex and function call
At moment, all tests has be passed. |
Thanks for the updates! The changes are now bigger than I'd expected, but I've had a quick look and they seem reasonable. I'll review more thoroughly over the next day or two, but if my local code continues to work as expected I'll merge. Thanks, again. You did a great job making the changes to the object/ implementations :) |
Hello! |
This PR allow to acess alternatively hash values using DOT
a.b
separator instead ofa["b"]
.