Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to vim-plug #864 #866

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Migration to vim-plug #864 #866

wants to merge 6 commits into from

Conversation

nandalopes
Copy link
Contributor

@nandalopes nandalopes commented May 28, 2021 •
edited

This PR changes vim plugin manager from Vundle to vim-plug.

Close #864

@nandalopes
VimPlug migration
cfc1235 
Rename Vundle module to VimPlug
@nandalopes
feat(vim): migrate to vim-plug
2943c00
@nandalopes
chore(vim): migrate to vim-plug
a7a9bd6 
- Rename files
- Change plugin action Bundle -> Plug

Signed-off-by: Nanda Lopes <nandalopes@gmail.com>
@nandalopes
feat: save previous plugin set on migration
0406f4b
@nandalopes
chore(vim): update fzf post install hook
9399089
@nandalopes
chore(vim): fix typo in comments
fb79356 
- plugged.vim -> plugins.d/main.vim
- plug.vim -> plugins.d/main.vim

Signed-off-by: Nanda Lopes <nandalopes@gmail.com>
@lfilho
Copy link
Collaborator

lfilho commented Jul 5, 2021

Last time I tried a similar migration (to NeoBundle, back in 2013), @skwp brought up some reasons / conditions not to do this. So I'll defer to him to address this new attempt 😇 .

I like vim-plug a lot and it's what I've been using in my own fork for some years now as well

@nandalopes
Copy link
Contributor Author

I've tested and passed:

  • Fresh install
  • Fresh install and yadr-plugin-add
  • Migrated without previous .vundles.local
  • Migrated with .vundles.local *

I've managed to copy .vundles.local to .local.bundles, but need some help to change from Bundle commands to Plug commands, or some message on this type of migration, maybe.

@nandalopes
Copy link
Contributor Author

nandalopes commented Jul 6, 2021 •
edited

I've uploaded a fresh-install gif:

yadr fresh-install with vim-plug

@thecadams
Copy link

Hi folks, have been a happy user of this repo for many years.

This is a nice change. Just wondering - do the utilites and docs mentioned in https://github.com/skwp/dotfiles/blob/master/doc/vim/manage_plugins.md need to be changed too?

@nandalopes
Copy link
Contributor Author

No need to change the docs. I've managed the utilities to use the same aliases, but changing internal implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migration to vim-plug
3 participants
@nandalopes @lfilho @thecadams