Added the option to use multithreading when encoding webp #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
First of all, thank you for creating an awesome JVM library and providing it as open source.
I'm using the scrimage library for webp encoding. It seems to be using
cwebpfor encoding, and I can apply several option flags, includingnoalpha. I think it would be nice to additionally support the (-mt) multithread option provided by cwebp.The multithread feature is already provided in libwebp-1.3.2 cwebp, so if it is provided as an optional flag, I think it will work fine. I've added a new constructor for WebpWriter (keeping the old ones), and I don't think there should be any problems with backwards compatibility since the mt option defaults to false.
If you don't mind, I hope you will accept my MR.