Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jbranchaud/sks 91 set up payment options for epic web #1473

Merged
merged 5 commits into from Mar 27, 2024

Conversation

jbranchaud
Copy link
Contributor

  • feat(ew): add PaymentOptions, remove stripeData
  • feat(ew): remove last Stripe import
  • feat(ew): use payment options in inngest funcs

rain

Copy link

linear bot commented Mar 26, 2024

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
badass-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 5:21pm
colt-steele ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 5:21pm
devrel-fyi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 5:21pm
epic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 5:21pm
pro-aws ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 5:21pm
pro-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 5:21pm
skill-stack-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 5:21pm
testing-javascript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 5:21pm
total-typescript-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 5:21pm

Comment on lines 18 to 20
if (!stripe) {
throw new Error('Payment provider (Stripe) is missing')
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelhooks does this make sense as a way to handle the "Stripe provider not defined" scenario? This is mostly to let TS know that it definitely exists below since it has to get defined in the API setup for the app to work.

Or is there a more idiomatic inngest way of bailing if the payment provider isn't configured?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will keep retrying. there's a specific error if you want it to stop trying

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will keep retrying. there's a specific error if you want it to stop trying

nice, I updated it to use NonRetriableError 🙌 https://www.inngest.com/docs/guides/error-handling#preventing-retries-with-non-retriable-errors

@kodiakhq kodiakhq bot merged commit 8081b7f into main Mar 27, 2024
4 of 13 checks passed
@kodiakhq kodiakhq bot deleted the jbranchaud/sks-91-set-up-payment-options-for-epic-web branch March 27, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants