feat(er-next): miscellaneous stuff #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DrShpongle
commented
Mar 26, 2024
| @@ -118,7 +119,8 @@ export const WorkshopSchema = z.object({ | |||
| _updatedAt: z.string(), | |||
| _createdAt: z.string(), | |||
| description: z.string().nullable(), | |||
| state: z.string(), // TODO: make this a union/literal of the 3 states | |||
There was a problem hiding this comment.
fixed this TODO (but used only the 2 states - "draft" and "published". What's supposed to be the third one?)
DrShpongle
commented
Mar 26, 2024
apps/epic-react/src/pages/learn.tsx
Outdated
| } | ||
| })} | ||
| </ul> | ||
| if (resource._type === 'section' && resource?.resources) { |
There was a problem hiding this comment.
Can't appease the TS here, can you please take a look @jbranchaud ?
DrShpongle
commented
Mar 26, 2024
apps/epic-react/src/pages/learn.tsx
Outdated
| key={resource._id} | ||
| title={resource.title} | ||
| workshopSlug={computedResource.slug.current} | ||
| resourceSlug={resource.resources[0].slug} |
There was a problem hiding this comment.
Can't appease the TS here, can you please take a look @jbranchaud ?
DrShpongle
commented
Mar 26, 2024
|
|
||
| const paths = tutorials.flatMap((tutorial: any) => { | ||
| const paths = [...tutorials, ...bonuses].flatMap((tutorial: any) => { |
There was a problem hiding this comment.
decided to merge workshops (it was "tutorials" here before, I didn't change) and bonuses here
jbranchaud
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
bonus&interview)Learn page
Livestreams page