feat: move Payment Options over to commerce-server #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joelhooks
approved these changes
Mar 21, 2024
…ymentprovider-pieces-into-commerce
kodiakhq
bot
deleted the
jbranchaud/sks-86-move-paymentoptions-and-paymentprovider-pieces-into-commerce
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things that are related to Payments conceptually belong in the commerce-server.
Plus, both the commerce-server and the skill-api packages need access to Payment Provider imports. Since skill-api depends on commerce-server, not the other way around, these concepts need to be moved into commerce-server so as not to create a circular dependency.