feat: compare previous email on customer updated #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were comparing two emails that were always identical because the user tied to the Merchant Customer record had already been updated. Because of this, an email was never getting sent to the new user.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jbranchaud
commented
Mar 8, 2024
Comment on lines
+298
to
+304
| const {previous_attributes} = z | ||
| .object({ | ||
| previous_attributes: z | ||
| .object({email: z.string().optional()}) | ||
| .optional(), | ||
| }) | ||
| .parse(event.data) |
There was a problem hiding this comment.
We can pull the previous email out of previous_attributes that stripe includes in its webhook payload.
joelhooks
approved these changes
Mar 8, 2024
kodiakhq
bot
deleted the
jbranchaud/sks-81-transfer-purchase-doesnt-trigger-email-to-new-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were comparing two emails that were always identical
because the user tied to the Merchant Customer record had already been
updated. Because of this, an email was never getting sent to the new
user.