feat(er-next): transfer colors & core styles + implement Navigation #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DrShpongle
commented
Mar 7, 2024
| className?: string | ||
| } | ||
|
|
||
| const sellingLive = true |
There was a problem hiding this comment.
At the moment I'm not sure how we handle selling so hardcoded this for now
DrShpongle
commented
Mar 7, 2024
|
|
||
| const sellingLive = true | ||
|
|
||
| const isTeamPurchaser = (user: any) => { |
There was a problem hiding this comment.
Here I define if user has only Team purchase
DrShpongle
commented
Mar 7, 2024
| }), | ||
| )} | ||
| > | ||
| {/* TODO: <Feedback /> component */} |
There was a problem hiding this comment.
Feedback component is not implemented yet - have to investigate how it connect to the API
DrShpongle
commented
Mar 7, 2024
| <Logo isMobile={isMobile} /> | ||
| </Link> | ||
|
|
||
| {/* TODO: reference: epic-react-gatsby-main/src/layouts/video-resource-page-layout.js */} |
There was a problem hiding this comment.
Progress subcomponent in navigation for the large viewports is not implemented yet
DrShpongle
commented
Mar 7, 2024
| TooltipTrigger, | ||
| } from '@skillrecordings/ui' | ||
|
|
||
| const Feedback: React.FC<{children: React.ReactNode}> = ({children}) => { |
There was a problem hiding this comment.
This component is on WIP stage at the moment
DrShpongle
commented
Mar 7, 2024
| DialogTitle, | ||
| DialogTrigger, | ||
| DialogPortal, |
There was a problem hiding this comment.
Export more primitives for the Dialog component
jbranchaud
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
/loginpage gets adjustedto be continued...
Learn page with Navigation
Login page