New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jbranchaud/tjs 62 Make EW stripe webhook handler deal with TJS stripe events #1427
Merged
kodiakhq
merged 6 commits into
main
from
jbranchaud/tjs-62-add-testing-javascript-webhook-endpoint-to-list-of-stripe
Mar 7, 2024
Merged
jbranchaud/tjs 62 Make EW stripe webhook handler deal with TJS stripe events #1427
kodiakhq
merged 6 commits into
main
from
jbranchaud/tjs-62-add-testing-javascript-webhook-endpoint-to-list-of-stripe
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jbranchaud
changed the title
jbranchaud/tjs 62 add testing javascript webhook endpoint to list of stripe
jbranchaud/tjs 62 Make EW stripe webhook handler deal with TJS stripe events
Mar 7, 2024
joelhooks
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏🏻
…hook-endpoint-to-list-of-stripe
kodiakhq
bot
deleted the
jbranchaud/tjs-62-add-testing-javascript-webhook-endpoint-to-list-of-stripe
branch
March 7, 2024 20:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I've tested this locally against TT, EW and TJS. All looks good.
This PR makes some updates to Stripe webhook handling in the skill-api. The
epic-web
app receives stripe webhook events for all kcd-products. For the events that are for one of the other kcd-products (e.g. testing-javascript), they will be forwarded along to that app so that it can process them in the proper context (that context is important for things like sending emails).We know what app a webhook is meant for because we include the
siteName
in the webhook metadata. At this point, this is mainly relevant forcustomer.updated
andcheckout.session.created
.