fix(TJS-61): testing javascript course completion certificate #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jbranchaud
reviewed
Mar 1, 2024
Comment on lines
8
to
13
| const paymentOptions = defaultPaymentOptions({ | ||
| stripeProvider: StripeProvider({ | ||
| stripeSecretKey: process.env.STRIPE_SECRET_TOKEN, | ||
| apiVersion: '2020-08-27', | ||
| }), | ||
| }) |
There was a problem hiding this comment.
why is this being commented out?
this is the direction we're heading to support multi-provider payments.
There was a problem hiding this comment.
@jbranchaud I think that correct import from is '@skillrecordings/skill-api/src' and not '@skillrecordings/skill-api/. Can you confirm?
There was a problem hiding this comment.
now build fails on this:
There was a problem hiding this comment.
The import should have already been correct. I think it may be an issue of re-building skill-api locally (cd packages/skill-api; pnpm dev).
There was a problem hiding this comment.
can't build on my side. Does it work on yours?
DrShpongle
force-pushed
the
yevhen/tjs-61-testing-javascript-course-completion-certificate
branch
from
43c93d9
to
87bbb47
Compare
DrShpongle
force-pushed
the
yevhen/tjs-61-testing-javascript-course-completion-certificate
branch
from
6a82307
to
0d9fab8
Compare
jbranchaud
approved these changes
Mar 4, 2024
kodiakhq
bot
deleted the
yevhen/tjs-61-testing-javascript-course-completion-certificate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things:
courseCompletedcalculation function so that "Download Certificate" appears after all lesson get completed now.About the person who reported about this issue - I think we should let him know he needs to rewatch last lessons in each of the modules to get them completed and get certificate download link eventually