feat: leave as string to avoid as number

skillrecordings · Mar 26, 2024 · 3f5a192 · 3f5a192
1 parent 1615382
commit 3f5a192
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/packages/convertkit-react-ui/src/forms/subscribe-to-convertkit/index.tsx b/packages/convertkit-react-ui/src/forms/subscribe-to-convertkit/index.tsx
@@ -10,7 +10,7 @@ export type SubscribeFormProps = {
   submitButtonElem?: React.ReactElement
   onError?: (error?: any) => void
   onSuccess?: (subscriber?: ConvertkitSubscriber, email?: string) => void
-  formId?: number
+  formId?: string
   subscribeApiURL?: string
   id?: string
   fields?: Record<string, string>

diff --git a/packages/convertkit-react-ui/src/hooks/use-convertkit-form.ts b/packages/convertkit-react-ui/src/hooks/use-convertkit-form.ts
@@ -12,13 +12,13 @@ import {
  **/
 export function useConvertkitForm({
   submitUrl = CONVERTKIT_SUBSCRIBE_API_URL,
-  formId = (CONVERTKIT_SIGNUP_FORM || 0) as number,
+  formId = CONVERTKIT_SIGNUP_FORM || '0',
   fields,
   onSuccess,
   onError,
 }: {
   submitUrl?: string
-  formId?: number
+  formId?: string
   onSuccess: (subscriber: ConvertkitSubscriber, email?: string) => void
   onError: (error?: any) => void
   fields?: any

diff --git a/packages/skill-lesson/convertkit/convertkit-subscribe-form.tsx b/packages/skill-lesson/convertkit/convertkit-subscribe-form.tsx
@@ -14,7 +14,7 @@ export type SubscribeFormProps = {
   submitButtonElem?: React.ReactElement
   onError?: (error?: any) => void
   onSuccess?: (subscriber?: Subscriber, email?: string) => void
-  formId?: number
+  formId?: string
   subscribeApiURL?: string
   id?: string
   fields?: Record<string, string>

diff --git a/packages/skill-lesson/hooks/use-convertkit-form.ts b/packages/skill-lesson/hooks/use-convertkit-form.ts
@@ -9,15 +9,15 @@ import {
 
 export function useConvertkitForm({
   submitUrl = CONVERTKIT_SUBSCRIBE_API_URL,
-  formId = (CONVERTKIT_SIGNUP_FORM || 0) as number,
+  formId = CONVERTKIT_SIGNUP_FORM || '0',
   fields,
   onSuccess,
   onError,
   validationSchema,
   validateOnChange = false,
 }: {
   submitUrl?: string
-  formId?: number
+  formId?: string
   onSuccess: (subscriber: Subscriber, email?: string) => void
   onError: (error?: any) => void
   fields?: any