Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove post purchase survey #1426

Merged
merged 3 commits into from Mar 19, 2024
Merged

remove post purchase survey #1426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a048a1a
remove post purchase survey
zacjones93 Mar 19, 2024
e558718
Merge branch 'main' of github.com:skillrecordings/egghead-next into z…
zacjones93 Mar 19, 2024
c16b080
remove tally survey component
zacjones93 Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/components/pages/confirm/membership/index.tsx
View file
Open in desktop
Expand Up @@ -7,7 +7,6 @@ import Spinner from '@/components/spinner'
import {IconTwitter} from '@/components/share'
import usePurchaseAndPlay from '@/hooks/use-purchase-and-play'
import {Topic} from '@/types'
import PostPurchase from '@/components/survey/tally/post-purchase'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you keeping this file around for now or can that get deleted too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought to keep it around but maybe it's cruft that should be removed because if we did a survey again we likely wouldn't be using this service

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not too hard to find and restore it from git history either

import {trpc} from '@/app/_trpc/client'
import {useAccount} from '@/hooks/use-account'

Expand Down Expand Up @@ -59,8 +58,6 @@ const ExistingMemberConfirmation: React.FC<
<StartLearning />
</div>
</div>

<PostPurchase email={data.customer.email} />
</>
) : null
}
Expand Down
17 changes: 0 additions & 17 deletions src/components/survey/tally/post-purchase.tsx
View file
Open in desktop

This file was deleted.