Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corrupt json #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alan01252
Copy link

@Alan01252 Alan01252 commented Dec 28, 2018

Tested on kibana locally this import succeeds and all the visualisations
appear to work as expected.

It's difficult to know if these are the latest versions of the
visualisations as the authors intended due to the complexity of the
nested json. As such this is more of a "best guess" of what the json
should be.

fixes #6

Tested on kibana locally this import succeeds and all the visualisations
appear to work as expected.

It's difficult to know if these are the latest versions of the
visualisations as the authors intended due to the complexity of the
nested json. As such this is more of a "best guess" of what the json
should be.
@CLAassistant
Copy link

CLAassistant commented Dec 28, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Alan01252
Copy link
Author

I think there's definitely some JSON missing, for instance, the "Test FLOW" visualisation, as shown in the image on the README for this example, is missing completely in original and in this pull request.

@lmangani
Copy link
Member

lmangani commented Dec 28, 2018

Thanks @Alan01252 are you referring to the Vega flows or the IP Flow Diagrams? IP Flow Diagram requires an additional Kibana plugin and can't be done with Vega juet yet.
image

@Alan01252
Copy link
Author

Alan01252 commented Dec 28, 2018

Thanks @Alan01252 are you referring to the Vega flows or the IP Flow Diagrams? IP Flow Diagram requires an additional Kibana plugin and can't be done with Vega juet yet.
image

Yep, that's the one I was referring to! Sorry, my misunderstanding!

@lmangani
Copy link
Member

@Alan01252 here's what was used for the demo, unfortunately no time to maintain it: https://github.com/lmangani/kibana_diagram

@Alan01252
Copy link
Author

@Imangani that's perfect thanks you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kibana-import json is broken
3 participants