Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AFS deployment #377

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add support for AFS deployment #377

wants to merge 7 commits into from

Conversation

ttpcodes
Copy link
Member

@ttpcodes ttpcodes commented Feb 8, 2020

This PR updates deploy.sh so that it is possible to deploy over AFS and avoid using SSH.

If the script detects aklog, it will assume that AFS is installed and authenticate with kinit to get a Kerberos ticket, authenticate to the SIPB cell, and use rsync to deploy CourseRoad. If not installed, this script should default back to SSH for deployment.

Copy link
Collaborator

@npfoss npfoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my system which aklog says aklog not found, yet I got the following printout when I ran the script:

Checking for AFS on this system
AFS detected, using AFS for deployment
Using kdo
./deploy.sh: 27: kdo: not found

Also, I think there's definitely some code duplication that could be avoided here... maybe making the production question separate and "no" just exiting, then doing the setup that's the same for both, then a ternary statement or something for the two lines which are different?

@npfoss
Copy link
Collaborator

npfoss commented Apr 3, 2020

Update from the meeting: we're starting to think maybe this is adding an unnecessary amount of added complexity for two fairly specific use cases. Discuss?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants