Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace null bytes before writing them to the csv file #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacobrobertbaca
Copy link
Contributor

@jacobrobertbaca jacobrobertbaca commented Dec 16, 2020

Description of change

replace null bytes before writing them to the csv file
https://stitchdata.atlassian.net/browse/SUP-2061

Manual QA steps

ran with this cloned connection
before change -> saw NULL bytes exception
after change -> no error

tested to make sure that we weren't incorrectly removing records that had the string '\0':

txt = 'fkld \0'
txt.replace('\0', '')
'fkld '
txt2 = '\0'
txt2.replace('\0', '')
'\0'

so if there is a string that is literally '\0' on the record, it will come through as '\0', and when we replace on the string, the '\0' does not get hit.

Risks

  • low

Rollback steps

  • revert this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant