TDL-20481 Update pks in schema of users stream #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbshah1212
requested review from
dbshah1212,
cosimon,
KrisPersonal and
RushiT0122
dbshah1212
approved these changes
Sep 6, 2022
savan-chovatiya
approved these changes
Sep 6, 2022
cosimon
reviewed
Sep 6, 2022
tap_jira/__init__.py
Outdated
Comment on lines
96
to
98
| # Update pk for users stream to key for on prem jira instance | ||
| if stream.tap_stream_id == "users" and Context.client.is_on_prem_instance: | ||
| stream.pk_fields = ["key"] |
There was a problem hiding this comment.
We already do this in generate_metadata(), can we refactor so we only have 1 place in code in which we generate our schema?
cosimon
reviewed
Sep 6, 2022
tap_jira/__init__.py
Outdated
| """ | ||
| if Context.client.is_on_prem_instance: | ||
| # ALL_STREAMS contains `Users` object at index 7 | ||
| streams_.ALL_STREAMS[7].pk_fields = ["key"] |
There was a problem hiding this comment.
We should not be making the ordering of the streams in ALL_STREAMS matter. Just call discover() in the sync function to get the catalog instead of loading the schema in 2 different places in code.
There was a problem hiding this comment.
We were already calling discovery but not using generated catalog which we updated.
RushiT0122
approved these changes
Sep 15, 2022
shantanu73
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
usersstream in sync mode.Manual QA steps
key-propertiesiskeyof users stream for on-prem Jira instance in the catalog.key-propertiesis updated tokeyinschemamessage ofusersstream for on-prem Jira instance.Risks
Rollback steps