Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around paginator flaw by querying issues in descending order #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gnilrets
Copy link

Description of change

Resolves #109 by querying issue data in descending update order.

Manual QA steps

  • I added more logging to manually demonstrate that a record can be skipped if another record is updated on a page that has been previously queried. After this change, we can get duplicates in this situation, which may be removed by downstream singer targets.

Risks

  • Dupes may not always be treated gracefully in targets.

Rollback steps

  • revert this branch

@singer-bot
Copy link

Hi @gnilrets, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental sync flaw
2 participants